typeck: minor pattern typing improvements #70386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Mar 26, 2020
Comment on lines
+68
to
+69
| LL | let NormalStruct { first_field, second_field , .. } = ns; | ||
| | ^^^^^^ |
There was a problem hiding this comment.
I'd like it if we could get around pointing at the closing brace and the preceding space, but that would complicate the span gather code quite dramatically...
There was a problem hiding this comment.
Trust me, I tried several clever iterations to fix that but I got nowhere. :)
estebank
reviewed
Mar 26, 2020
| @@ -62,18 +62,33 @@ error[E0638]: `..` required with struct marked as non-exhaustive | |||
| | | |||
| LL | let NormalStruct { first_field, second_field } = ns; | |||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
| | | |||
| help: add `..` at the end of the field list | |||
There was a problem hiding this comment.
Add some explanation along the lines of "add .. at the end of the field list to ignore all other fields".
r=me
|
@bors r=estebank |
|
📌 Commit da10963 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#69866 (Rename `def_span` to `guess_head_span`) - rust-lang#69878 (Tweak chained operators diagnostic) - rust-lang#70375 (avoid catching InterpError) - rust-lang#70386 (typeck: minor pattern typing improvements) - rust-lang#70389 (borrowck: prefer "value" over "`_`" in diagnostics) - rust-lang#70395 (Update cargo.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank