Add BinaryHeap::retain as suggested in #42849 #71485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Please also note in the documentation that this visits the elements in unsorted (and unspecified) order. r? @Amanieu for approval of the method. I suspect we may want to add retain_sorted as well. |
arlopurcell
force-pushed
the
binary_heap_retain
branch
from
90698d7 to
70c6c0e
Compare
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Could you create a separate tracking issue for this feature? Also as @Mark-Simulacrum said, please add a note in the docs that the iteration order is arbitrary (just like the
There is no efficient way to iterate over a heap in sorted order, so I would rather not add this method. |
|
|
I attempted to determine if there was an efficient way, but wasn't sure. That's enough reason for me though :) |
arlopurcell
force-pushed
the
binary_heap_retain
branch
from
70c6c0e to
177fd06
Compare
Amanieu
reviewed
Apr 23, 2020
arlopurcell
force-pushed
the
binary_heap_retain
branch
from
177fd06 to
787eddc
Compare
|
@bors r+ |
|
📌 Commit 787eddc has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 24, 2020
…manieu Add BinaryHeap::retain as suggested in rust-lang#42849 This PR implements retain for BinaryHeap as suggested in rust-lang#42849. This is my first PR for Rust, so please let me know if I should be doing anything differently, thanks!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#69456 (fix misleading type annotation diagonstics) - rust-lang#71330 (Only run dataflow for const qualification if type-based check would fail) - rust-lang#71480 (Improve PanicInfo examples readability) - rust-lang#71485 (Add BinaryHeap::retain as suggested in rust-lang#42849) - rust-lang#71512 (Remove useless "" args) - rust-lang#71527 (Miscellaneous cleanup in `check_consts`) - rust-lang#71534 (Avoid unused Option::map results) - rust-lang#71535 (Fix typos in docs for keyword "in") Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements retain for BinaryHeap as suggested in #42849.
This is my first PR for Rust, so please let me know if I should be doing anything differently, thanks!