Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE for broken or-pattern in async fn #71557

Merged
merged 1 commit into from
May 10, 2020
Merged

Fix ICE for broken or-pattern in async fn #71557

merged 1 commit into from
May 10, 2020
+102 −19

Conversation

matthewjasper
Copy link
Contributor

closes #71297

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2020
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2020
@matthewjasper
Copy link
Contributor Author

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned cramertj May 8, 2020
oli-obk
oli-obk reviewed May 8, 2020
View reviewed changes
src/librustc_mir_build/build/matches/mod.rs
} => {
if is_primary {
f(self, mutability, name, mode, var, pattern.span, ty, pattern_user_ty.clone());
}
if let Some(subpattern) = subpattern.as_ref() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't subpatterns only relevant for the primary, too, as each variable must occur in all variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this PR is that we can't assume that patterns are well formed because the error isn't fatal.

@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2020

📌 Commit 4dd47d3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 9, 2020
@Dylan-DPC
Rollup merge of rust-lang#71557 - matthewjasper:mir-asymmetric-or-pat…
eeacf8d 
…tern, r=oli-obk

Fix ICE for broken or-pattern in async fn

closes rust-lang#71297
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 9, 2020
Closed
@bors
Copy link
Contributor

bors commented May 10, 2020

⌛ Testing commit 4dd47d3 with merge 6f5c782...

@bors
Copy link
Contributor

bors commented May 10, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 6f5c782 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2020
@bors bors merged commit 6f5c782 into rust-lang:master May 10, 2020
@matthewjasper matthewjasper deleted the mir-asymmetric-or-pattern branch May 10, 2020 08:26
@SNCPlay42 SNCPlay42 mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal compiler error: no entry found for key
6 participants
@matthewjasper @rust-highfive @oli-obk @bors @cramertj @joelpalmer