Rollup of 4 pull requests #72555

Dylan-DPC-zz · 2020-05-25T01:07:35Z

Successful merges:

Implement Sync for `process::Command on unix and vxworks #72472 (Implement Sync for `process::Command on unix and vxworks)
Improve E0601 explanation #72495 (Improve E0601 explanation)
Miri casts: do not blindly rely on dest type #72525 (Miri casts: do not blindly rely on dest type)
Fix InlineAsmOperand expresions being visited twice during liveness checking #72537 (Fix InlineAsmOperand expresions being visited twice during liveness checking)

Failed merges:

r? @ghost

…hecking

@cuviper

…lnay Implement `Sync` for `process::Command on unix and vxworks Closes rust-lang#72387. r? @cuviper

@Dylan-DPC

…an-DPC Improve E0601 explanation r? @Dylan-DPC

@eddyb

Miri casts: do not blindly rely on dest type Make sure that we notice when the MIR is bad and the casted-to and destination type are e.g. of different size, as suggested by @eddyb.

…enkov Fix InlineAsmOperand expresions being visited twice during liveness checking

Dylan-DPC-zz · 2020-05-25T01:07:59Z

@bors r+ rollup=never p=4

bors · 2020-05-25T01:08:00Z

📌 Commit a919ef4 has been approved by Dylan-DPC

bors · 2020-05-25T01:42:17Z

⌛ Testing commit a919ef4 with merge d3d9d86c1fd4f6d7e45541d58cfda5fe7326db9d...

rust-highfive · 2020-05-25T02:16:57Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 3'
Agent machine name: 'fv-az578'
Current agent version: '2.169.0'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200517.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200517.1/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.2)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/1f052108-e196-4f72-bfea-788a0f606c33.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72555/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72555/merge:refs/remotes/pull/72555/merge
---
 ---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> 091087e35a36
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
...........................................................................i........................ 1800/10222
.................................................................................................... 1900/10222
..............................................................................................i..i.. 2000/10222
.................................................................................................... 2100/10222
....................................................................................iiiii........... 2200/10222
.................................................................................................... 2400/10222
.................................................................................................... 2500/10222
.................................................................................................... 2600/10222
.................................................................................................... 2700/10222
---
...........i...............i........................................................................ 5200/10222
.................................................................................................... 5300/10222
..........................................................i......................................... 5400/10222
...................................................i................................................ 5500/10222
..............................................................ii.ii........i...i.....F.............. 5600/10222
....i............................................................................................... 5800/10222
............i....................................................................................... 5900/10222
................................................................ii.................................. 6000/10222
...i................................................................................................ 6100/10222
...i................................................................................................ 6100/10222
.................................................................................................... 6200/10222
.................................................................................................... 6300/10222
.........................ii...i..ii...........i..................................................... 6400/10222
.................................................................................................... 6600/10222
.................................................................................................... 6700/10222
.................................................................................................... 6700/10222
..........................................................i..ii..................................... 6800/10222
.................................................................................................... 7000/10222
.................................................................................................... 7100/10222
............i....................................................................................... 7200/10222
.................................................................................................... 7300/10222
---
.................................................................................................... 8100/10222
.................................................................................................... 8200/10222
.................................................................................................... 8300/10222
......................................i............................................................. 8400/10222
............................................................................................iiiiii.i 8500/10222
iiiii.i............................................................................................. 8600/10222
.................................................................................................... 8800/10222
.................................................................................................... 8900/10222
.................................................................................................... 9000/10222
.................................................................................................... 9100/10222
---

---- [ui] ui/json-short.rs stdout ----
diff of stderr:

- {"message":"`main` function not found in crate `json_short`","code":{"code":"E0601","explanation":"No `main` function was found in a binary crate. To fix this error, add a
- `main` function. For example:
+ {"message":"`main` function not found in crate `json_short`","code":{"code":"E0601","explanation":"No `main` function was found in a binary crate.
+ To fix this error, add a `main` function:
3 
4 ```
5 fn main() {
5 fn main() {


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short/json-short.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args json-short.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/json-short.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--json=diagnostic-short" "--error-format=json" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
/checkout/src/test/ui/json-short.rs:1:63: error[E0601]: `main` function not found in crate `json_short`

------------------------------------------


---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 1:03:07
Build completed unsuccessfully in 1:03:07
== clock drift check ==
  local time: Mon May 25 02:16:51 UTC 2020
  network time: Mon, 25 May 2020 02:16:51 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72555/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72555/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (3991) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-05-25T02:48:51Z

💔 Test failed - checks-azure

LeSeulArtichaut and others added 12 commits May 22, 2020 18:33

Implement Sync for `process::Command on unix and vxworks

01630b2

Improve E0601 explanation

d01f131

make some cast helpers infallible

fbc6f2c

Miri casts: do not blindly rely on dest type

b97ed1a

Fix unsizing casts

b9b1554

Fix InlineAsmOperand expresions being visited twice during liveness c…

be2fd61

…hecking

use helper method for determining size of int type

7b98552

comment nit

8b5ba4a

Rollup merge of rust-lang#72472 - LeSeulArtichaut:sync-command, r=dto…

5a26be3

…lnay Implement `Sync` for `process::Command on unix and vxworks Closes rust-lang#72387. r? @cuviper

Rollup merge of rust-lang#72495 - GuillaumeGomez:cleanup-e0601, r=Dyl…

bc10b31

…an-DPC Improve E0601 explanation r? @Dylan-DPC

Rollup merge of rust-lang#72525 - RalfJung:miri-cast-checks, r=eddyb

8b65235

Miri casts: do not blindly rely on dest type Make sure that we notice when the MIR is bad and the casted-to and destination type are e.g. of different size, as suggested by @eddyb.

Rollup merge of rust-lang#72537 - Amanieu:fix-asm-liveness, r=petroch…

a919ef4

…enkov Fix InlineAsmOperand expresions being visited twice during liveness checking

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 25, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 25, 2020

Dylan-DPC-zz closed this May 25, 2020

JohnTitor added the rollup A PR which is a rollup label May 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 4 pull requests #72555

Rollup of 4 pull requests #72555

Dylan-DPC-zz commented May 25, 2020

Dylan-DPC-zz commented May 25, 2020

bors commented May 25, 2020

bors commented May 25, 2020

rust-highfive commented May 25, 2020

bors commented May 25, 2020

Rollup of 4 pull requests #72555

Rollup of 4 pull requests #72555

Conversation

Dylan-DPC-zz commented May 25, 2020

Dylan-DPC-zz commented May 25, 2020

bors commented May 25, 2020

bors commented May 25, 2020

rust-highfive commented May 25, 2020

bors commented May 25, 2020