-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: use Display for exit status instead of Debug, see #74832 for justification #74841
Conversation
…g#74832 for justification
(rust_highfive has picked a reviewer for you, use r? to override) |
r=me, but looks like ci is failing? |
@Mark-Simulacrum it's because Display isn't implemented for Result (it's implemented for both ExitStatus and io::Error). It would be easy to implement it and I could do it as part of the PR (it would have to come in two parts since it doesn't exist in stage0), however was there a reason it wasn't already implemented? Seems like such an obvious thing to have. |
Display is not implemented for Option either so I figure this is some sort of libraries design decision, I'll update this PR to case-switch over the possibilities. |
Yes, lack of Display impls for Result and Option is intentional - there's no universal user facing representation of either. @bors r+ |
📌 Commit 3dcab29 has been approved by |
@Mark-Simulacrum I decided to just rewrite that section since it was repetitive and also had bugs (e.g. if you set both on-fail and RUSTC_PRINT_STEP_TIMINGS it wouldn't work correctly). It also allows us to get rid of the slightly messy |
@bors r+ |
📌 Commit e7089a9 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
No description provided.