Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document unsafety in library/core/src/slice/mod.rs #75066

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Document unsafety in library/core/src/slice/mod.rs #75066

merged 6 commits into from
Aug 12, 2020

Conversation

poliorcetics
Copy link
Contributor

Restart where #73555 left off, helping with #66219.

@rust-highfive
Copy link
Collaborator

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2020
LukasKalbertodt
LukasKalbertodt suggested changes Aug 8, 2020
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I have added some inline comments, some of which are only small nits.

library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
LukasKalbertodt
LukasKalbertodt suggested changes Aug 8, 2020
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update and for not amending/force-pushing -- a separate commit makes reviewing updates for these kinds of PRs a lot easier.

Three inline comments still.

library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
LukasKalbertodt
LukasKalbertodt suggested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one point left!

library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
@poliorcetics poliorcetics mentioned this pull request Aug 11, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 12, 2020
@JohnTitor
Rollup merge of rust-lang#75422 - poliorcetics:tidy-accept-more-safet…
a8b0a3c 
…y-comments, r=Mark-Simulacrum

Accept more safety comments

This accepts more `// SAFETY:` comments from `tidy`.

This is done after the current behaviour of requiring text one the same line (because spaces are stripped so the last space never pass if there is no text on the same line) bit me once more in rust-lang#75066

This could potentially accept empty `// SAFETY:` comments but `tidy` is an internal tool used only here so my reasoning is reviews will catch those.
@LukasKalbertodt
Copy link
Member

@bors r+ rollup=iffy

Again, thanks a lot!

@bors
Copy link
Contributor

bors commented Aug 12, 2020

📌 Commit a308e74 has been approved by LukasKalbertodt

@bors
Copy link
Contributor

bors commented Aug 12, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2020
@pietroalbini
Copy link
Member

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Aug 12, 2020

⌛ Testing commit a308e74 with merge ded20c9...

@bors
Copy link
Contributor

bors commented Aug 12, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: LukasKalbertodt
Pushing ded20c9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 12, 2020
@bors bors merged commit ded20c9 into rust-lang:master Aug 12, 2020
This was referenced Aug 12, 2020
Merged
Merged
@poliorcetics poliorcetics deleted the document-unsafety-in-core-slice branch August 12, 2020 17:27
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasKalbertodt LukasKalbertodt LukasKalbertodt requested changes

Assignees

@LukasKalbertodt LukasKalbertodt

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@poliorcetics @rust-highfive @LukasKalbertodt @bors @pietroalbini @cuviper