Fix suggestion to use lifetime in type and in assoc const #75372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @lcnr |
estebank
changed the title
estebank
force-pushed
the
lt-sugg-in-type
branch
from
82443fb to
fdeb382
Compare
|
cc @JohnTitor |
lcnr
reviewed
Aug 11, 2020
estebank
force-pushed
the
lt-sugg-in-type
branch
from
fdeb382 to
6a3deb0
Compare
lcnr
approved these changes
Aug 12, 2020
| LL | const A: &str = ""; | ||
| LL | const B: S = S { s: &() }; | ||
| LL | const C: &'_ str = ""; | ||
| LL | const D: T<'a, 'a> = T { a: &(), b: &() }; |
There was a problem hiding this comment.
That snippet is somewhat unfortunate, but I don't think there is something we can do here 🤷
|
@bors r+ rollup |
|
📌 Commit 6a3deb0 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Aug 13, 2020
Fix suggestion to use lifetime in type and in assoc const _Do not merge until rust-lang#75363 has landed, as it has the test case for this._ * Account for associated types * Associated `const`s can't have generics (fix rust-lang#74264) * Do not suggest duplicate lifetimes and suggest `for<'a>` more (fix rust-lang#72404)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 13, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75189 (Fix wasi::fs::OpenOptions to imply write when append is on) - rust-lang#75201 (Fix some Clippy warnings in librustc_serialize) - rust-lang#75372 (Fix suggestion to use lifetime in type and in assoc const) - rust-lang#75400 (Fix minor things in the `f32` primitive docs) - rust-lang#75449 (add regression test for rust-lang#74739 (mir const-prop bug)) - rust-lang#75451 (Clean up E0751 explanation) - rust-lang#75455 (Use explicit path link in place for doc in time) - rust-lang#75457 (Remove some dead variants in LLVM FFI) - rust-lang#75466 (Move to intra doc links whenever possible within std/src/lib.rs) - rust-lang#75469 (Switch to intra-doc links in `std/io/mod.rs`) - rust-lang#75473 (Flip order of const & type) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until #75363 has landed, as it has the test case for this.
consts can't have generics (fix Suggestion diagnostic for new generic argument is placed at beginning of file #74264)for<'a>more (fix On missing HRLT annotation, we sometimes provide a slightly incorrect suggestion #72404)