-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cfg-stripping on generic parameters before invoking derive macros #76010
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
1f0b101
to
2f36045
Compare
@bors r+ |
📌 Commit 2f360451a2c0fee7c8e38dc1691702764ab623f0 has been approved by |
Fixes rust-lang#75930 This changes the tokens seen by a proc-macro. However, ising a `#[cfg]` attribute on a generic paramter is unusual, and combining it with a proc-macro derive is probably even more unusual. I don't expect this to cause any breakage.
2f36045
to
a97dcfa
Compare
@bors r=petrochenkov |
📌 Commit a97dcfa has been approved by |
⌛ Testing commit a97dcfa with merge 4aa7f66777680318c913502adec36ce81363cd7d... |
💔 Test failed - checks-azure |
It's a debuginfo failure on macOS:
This seems completely unrelated to my change. |
@bors retry |
…petrochenkov Run cfg-stripping on generic parameters before invoking derive macros Fixes rust-lang#75930 This changes the tokens seen by a proc-macro. However, ising a `#[cfg]` attribute on a generic paramter is unusual, and combining it with a proc-macro derive is probably even more unusual. I don't expect this to cause any breakage.
…petrochenkov Run cfg-stripping on generic parameters before invoking derive macros Fixes rust-lang#75930 This changes the tokens seen by a proc-macro. However, ising a `#[cfg]` attribute on a generic paramter is unusual, and combining it with a proc-macro derive is probably even more unusual. I don't expect this to cause any breakage.
Should this go through a crater run to confirm that? |
@joshtriplett |
@bors retry |
⌛ Testing commit a97dcfa with merge 9ecbc8c67feb853804555f8b7ed7cccddbebd270... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-actions |
@bors retry |
⌛ Testing commit a97dcfa with merge 022b4699a4384b68da645d21ea9de66c43c24d36... |
💔 Test failed - checks-azure |
@bors retry |
☀️ Test successful - checks-actions, checks-azure |
Fixes #75930
This changes the tokens seen by a proc-macro. However, ising a
#[cfg]
attributeon a generic paramter is unusual, and combining it with a proc-macro
derive is probably even more unusual. I don't expect this to cause any
breakage.