-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request, move part of std::io into core::io to be used by rust-libc such as relibc #77781
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Enable possible tests in core_io, other use upstream version directly core io update
Enable possible tests in core_io, other use upstream version directly core io update
…t-libc such as relibc Get libstd io to be portable. And makes platform dependent IoSliceMut can be customized by the user And give the default impl for windows/posix.
Enable possible tests in core_io, other use upstream version directly core io update
Enable possible tests in core_io, other use upstream version directly core io update
This has been brought up before a lot of times and I'm for moving a decent chunk of |
Thanks, I actually didn't move std::io to core::io yet, Just post a list of files that affect when I used them to implement posix c runtime. |
There was an RFC: rust-lang/rfcs#2262 |
☔ The latest upstream changes (presumably #78001) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
use #77922 instead |
Get std::io to be an core::io component so that can be used by runtime implemenation.
Especially for posix libc implemenation in rust with
and so on.
This is for https://github.com/redox-os/relibc
Also for
https://github.com/rulibc/rulibc
The fork of relibc that act as an msvcrt/mingw/cygwin/msys2 alternative on win32
glibc/musl alternative on linux world.
redox support will alomost unchanged with the upstream Thttps://github.com/redox-os/relibc
And makes platform dependent IoSliceMut can be customized by the user
And give the default impl for windows/posix.
#36193
related