-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FIXME comment in some incremental test suite #78670
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Could you explain briefly why these should be check-pass instead of build-pass? #62277 (comment) Especially for incremental, I'd be worried this isn't actually testing everything it should be. |
af217b6
to
13ccbb2
Compare
13ccbb2
to
f02296a
Compare
@bors r+ rollup |
📌 Commit f02296a has been approved by |
⌛ Testing commit f02296a with merge 64f8d36d387ec10b8d9b02316abfeeea719493f9... |
💔 Test failed - checks-actions |
@bors retry |
⌛ Testing commit f02296a with merge ae50593152d8e9a6ebd1de79afb65a5754c113df... |
💔 Test failed - checks-actions |
@bors retry cc @rust-lang/infra - is there anything we can do to make the network dependencies more reliable? Maybe we could cache the downloads in a docker container so we just have to download that? |
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#78670 (Remove FIXME comment in some incremental test suite) - rust-lang#79292 (Fix typo in doc comment for report_too_many_hashes) - rust-lang#79300 (Prevent feature information to be hidden if it's on the impl directly) - rust-lang#79302 (Add regression test for issue 73899) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Helps with #62277
I removed FIXME comment in some incremental tests with rustc_partition_codegened. This seems using codegen process. So it uses intentionally
build-pass