Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UnhashMap whenever we have a key of DefPathHash #80610

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

Aaron1011
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 2, 2021
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 2, 2021

⌛ Trying commit 0dc9b26 with merge 2c99097bd197675f29e771750ba166552f8f0966...

@bors
Copy link
Contributor

bors commented Jan 2, 2021

☀️ Try build successful - checks-actions
Build commit: 2c99097bd197675f29e771750ba166552f8f0966 (2c99097bd197675f29e771750ba166552f8f0966)

@rust-timer
Copy link
Collaborator

Queued 2c99097bd197675f29e771750ba166552f8f0966 with parent 0876f59, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 2, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (2c99097bd197675f29e771750ba166552f8f0966): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 2, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jan 2, 2021

A slight (<0.3%) improvement.

@varkor
Copy link
Member

varkor commented Jan 4, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 4, 2021

📌 Commit 0dc9b26 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jan 4, 2021

@bors rollup=never

Never rollup PR's that have a perf impact.

@bors
Copy link
Contributor

bors commented Jan 4, 2021

⌛ Testing commit 0dc9b26 with merge 887398f...

@bors
Copy link
Contributor

bors commented Jan 4, 2021

☀️ Test successful - checks-actions
Approved by: varkor
Pushing 887398f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2021
@bors bors merged commit 887398f into rust-lang:master Jan 4, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants