Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the bool::not method. #82786

Closed
wants to merge 5 commits into from
Closed

add the bool::not method. #82786

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db2efb
add the bool::not method.
Lokathor Mar 5, 2021
a25f6f7
document the method.
Lokathor Mar 5, 2021
828aa80
take out the new feature, we don't need a compiler feature.
Lokathor Mar 5, 2021
663ce13
add const modifier and inline attribute to bool::not
Lokathor Mar 11, 2021
00c5426
improve documentation.
Lokathor Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions library/core/src/bool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,17 @@ impl bool {
pub fn then<T, F: FnOnce() -> T>(self, f: F) -> Option<T> {
if self { Some(f()) } else { None }
}

/// Returns the opposite value.
///
/// # Examples
///
/// ```
/// assert_eq!(false.not(), true);
/// assert_eq!(true.not(), false);
/// ```
#[unstable(feature = "bool_not_method", issue = "none")]
m-ou-se marked this conversation as resolved.
Show resolved Hide resolved
pub fn not(self) -> Self {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method could be a const fn, did you decide not to make it one to keep it identical to the Not::not method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point actually. i only thought of it initially as a replacement for the Not trait being in the prelude, but we could probably go const here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially, it being constable already can also be an added argument for making it an inherent method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the intention is to make it possible to make trait impls const also, but we're pretty far from seeing that stabilized.

!self
}
}