debuginfo: Proper handling of lexical scopes and variable shadowing. #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has just been rebased. |
bors
added a commit
that referenced
this pull request
Aug 13, 2013
…ydon This pull request re-implements handling of visibility scopes and source code positions in debug info. It should now be very stable and properly handle + variable shadowing + expanded code (macros and the new for-loop de-sugaring, for example) + variables in the middle of nested scopes + bindings declared in the head of match statement arms. all of which did not work at all or did not work reliably before. Those interested in a more detailed description of the problems at hand, I kindly refer to http://michaelwoerister.github.io/2013/08/03/visibility-scopes.html Why doesn't the `populate_scope_map()` function use `syntax::visit`? Because it would not improve this particular AST walker (see: michaelwoerister@69dc790#commitcomment-3781426) Cheers, Michael
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2022
Don't suggest an empty variant name in `enum_variant_names` changelog: false positive fix: [`enum_variant_names`]: No longer suggests an empty variant name Fixes rust-lang#8324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request re-implements handling of visibility scopes and source code positions in debug info. It should now be very stable and properly handle
all of which did not work at all or did not work reliably before. Those interested in a more detailed description of the problems at hand, I kindly refer to http://michaelwoerister.github.io/2013/08/03/visibility-scopes.html
Why doesn't the
populate_scope_map()function usesyntax::visit?Because it would not improve this particular AST walker (see: michaelwoerister@69dc790#commitcomment-3781426)
Cheers,
Michael