-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listing of lints (eg via -W help
) to rustdoc
#83895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like CI is stuck, but r=me when it's working. |
This comment has been minimized.
This comment has been minimized.
dc3f11f
to
ad86be4
Compare
This comment has been minimized.
This comment has been minimized.
2cb42ba
to
f805937
Compare
This comment has been minimized.
This comment has been minimized.
@bors r+ This is awesome, thank you! Nice job on normalizing the lint names :) |
📌 Commit 4d23c8e has been approved by |
Hmm, won't it be confusing since a lot of rustc lints won't be run by rustdoc? E.g., fn main() {
[1, 2, 3].into_iter();
} with |
@camelid you can still enable those lints with
I think the list of lints enabled by default is separate, maybe we could just document that somewhere. |
Also, this is an implementation detail of how https://doc.rust-lang.org/nightly/rustdoc/advanced-features.html#cfgdoc-documenting-platform-specific-or-feature-specific-information works, it's not guarenteed. |
Rollup of 7 pull requests Successful merges: - rust-lang#82963 (Move `SharedContext` to `context.rs`) - rust-lang#83829 (rustc_target: Rely on defaults more in target specs) - rust-lang#83895 (Add listing of lints (eg via `-W help`) to rustdoc) - rust-lang#83902 (Update LLVM to support more wasm simd ops) - rust-lang#83903 (Fix typo in TokenStream documentation) - rust-lang#83910 (Update cargo) - rust-lang#83920 (Fix HashMap/HashSet LLDB pretty-printer after hashbrown 0.11.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Yes, but I think it could be confusing that |
That's separate from this change though, I don't think it should block it. |
Fixes #83883
r? @jyn514