Adjust self-type check to require equality #85511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit a4bb0ba533c6fa6cb073e9eae5630adb0de87a62 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never - might want to bisect to this if it causes regressions in the wild |
|
⌛ Testing commit a4bb0ba533c6fa6cb073e9eae5630adb0de87a62 with merge ca72f607d93aeb36c5c8eef02e7b1a4a17d60b8f... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@Mark-Simulacrum needs a bless? |
Mark-Simulacrum
force-pushed
the
eq-not-sup
branch
from
a4bb0ba to
4b4382d
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 4b4382d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter
SomeType::<X>::foo,self_tyisSomeType<X>and the method is defined in an impl onSomeType<A>. Previously, we required simply thatself_ty <: impl_ty, but this is too lax: we should require equality in order to use the method. This was found as part of unrelated work on never type stabilization, but also fixes one of the wf test cases.