Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "shrinking the deprecated method span" #86001

Merged
merged 2 commits into from
Jun 5, 2021

Conversation

richkadel
Copy link
Contributor

@richkadel richkadel commented Jun 4, 2021

Reverts #85617

Fixes: #86000

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 4, 2021

📌 Commit 2a6dd25 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2021
@Mark-Simulacrum
Copy link
Member

(Happy to re-r+ if you want to add a test for your minimal example in this PR as well)

@richkadel
Copy link
Contributor Author

Thanks. Sadly I don't have bandwidth for that today. Hopefully @hi-rustin can add that test as part of a re-land? If not, I can add it next week probably.

@richkadel
Copy link
Contributor Author

richkadel commented Jun 4, 2021

(Happy to re-r+ if you want to add a test for your minimal example in this PR as well)

@Mark-Simulacrum - I found the time to add the test. Since no warning is expected, the .stderr file didn't change. But I confirmed that with the original change, the warning is produced.

I think the original change only affects enum variants, and only if the enum derives from something like Debug.

If this works for you, please re-r+... Thanks!

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 4, 2021

📌 Commit 1384200 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 5, 2021

⌛ Testing commit 1384200 with merge 5ea1923...

@bors
Copy link
Contributor

bors commented Jun 5, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5ea1923 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2021
@bors bors merged commit 5ea1923 into rust-lang:master Jun 5, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected deprecation warnings on the declaration of the deprecated enum
5 participants