-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "shrinking the deprecated method span" #86001
Revert "shrinking the deprecated method span" #86001
Conversation
@bors r+ |
📌 Commit 2a6dd25 has been approved by |
(Happy to re-r+ if you want to add a test for your minimal example in this PR as well) |
Thanks. Sadly I don't have bandwidth for that today. Hopefully @hi-rustin can add that test as part of a re-land? If not, I can add it next week probably. |
Note, the `Debug` impl is required.
@Mark-Simulacrum - I found the time to add the test. Since no warning is expected, the I think the original change only affects If this works for you, please re-r+... Thanks! |
@bors r+ |
📌 Commit 1384200 has been approved by |
☀️ Test successful - checks-actions |
Reverts #85617
Fixes: #86000
r? @Mark-Simulacrum