Remove unnecessary trailing whitespace from error messages #86197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #86399) made this pull request unmergeable. Please resolve the merge conflicts. |
FabianWolff
force-pushed
the
trailing-whitespace
branch
from
b8e0a1a to
2228740
Compare
|
☔ The latest upstream changes (presumably #87003) made this pull request unmergeable. Please resolve the merge conflicts. |
FabianWolff
force-pushed
the
trailing-whitespace
branch
from
2228740 to
9bc1c4d
Compare
|
☔ The latest upstream changes (presumably #87042) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @JohnTitor @FabianWolff: could you fix the merge conflicts? Once you've fixed them, you should be able to mark your PR as ready for review with @rustbot author |
This comment has been minimized.
This comment has been minimized.
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-author
FabianWolff
force-pushed
the
trailing-whitespace
branch
from
9bc1c4d to
df0dfd4
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #87698) made this pull request unmergeable. Please resolve the merge conflicts. |
FabianWolff
force-pushed
the
trailing-whitespace
branch
from
df0dfd4 to
ee300b6
Compare
|
@bors r+ rollup |
|
📌 Commit ee300b6 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2021
…JohnTitor Remove unnecessary trailing whitespace from error messages Some error messages currently contain unnecessary trailing whitespace. There are some legitimate reasons for having trailing whitespace in the output, such as for uniform indentation of possibly-empty input lines, but the whitespace I have addressed here occurs in a line used only for spacing, and I see no reason why that should have trailing whitespace (spacing lines inserted in other places also don't have trailing whitespace). I have also removed a superfluous call to `buffer.putc()`, which has no effect because the same character is already placed there by `draw_col_separator()`. Use `git diff --ignore-space-at-eol` to see my changes; otherwise the diff is quite large due to the whitespace removed from expected outputs in `src/test/ui/`.
|
Failed in rollup: #87741 (comment) |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
FabianWolff
force-pushed
the
trailing-whitespace
branch
from
ee300b6 to
f8372f8
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ p=1 |
|
📌 Commit f8372f8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error messages currently contain unnecessary trailing whitespace. There are some legitimate reasons for having trailing whitespace in the output, such as for uniform indentation of possibly-empty input lines, but the whitespace I have addressed here occurs in a line used only for spacing, and I see no reason why that should have trailing whitespace (spacing lines inserted in other places also don't have trailing whitespace).
I have also removed a superfluous call to
buffer.putc(), which has no effect because the same character is already placed there bydraw_col_separator().Use
git diff --ignore-space-at-eolto see my changes; otherwise the diff is quite large due to the whitespace removed from expected outputs insrc/test/ui/.