add various coments to explain how the TAIT code works #86437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
spastorino
approved these changes
Jun 18, 2021
oli-obk
requested changes
Jun 18, 2021
| /// * `anon_ty` would be `Box<Foo<T>>` where `Foo` is an opaque type | ||
| /// scoped to this function (note that it is parameterized by the | ||
| /// generics of `foo`). | ||
| /// * `revealed_ty` would be `Box<(Foo<T>, u32)>` |
There was a problem hiding this comment.
Suggested change
| /// * `revealed_ty` would be `Box<(Foo<T>, u32)>` | |
| /// * `revealed_ty` would be `Box<(T, u32)>` |
There was a problem hiding this comment.
and then this would actually just be (T, u32)
| /// | ||
| /// In terms of our function parameters: | ||
| /// | ||
| /// * `anon_ty` would be `Box<Foo<T>>` where `Foo` is an opaque type |
There was a problem hiding this comment.
Isn't the anon_ty just Foo<T>?
There was a problem hiding this comment.
No, it's not. It's the return type, which contains opaque types (but also maybe other stuff). That's explicitly why I included the Box in the example. Let me clarify that.
|
@bors r=oli-obk |
|
📌 Commit 831759a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 19, 2021
add various coments to explain how the TAIT code works r? `@oli-obk`
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk