Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove unnecessary extern crate aliases #87120

Merged
merged 2 commits into from
Jul 14, 2021
Merged

rustdoc: Remove unnecessary extern crate aliases #87120

merged 2 commits into from
Jul 14, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 14, 2021

No description provided.

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 14, 2021
@rust-highfive
Copy link
Collaborator

Updates src/tools/cargo.

cc @ehuss

@rust-highfive
Copy link
Collaborator

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2021
@jyn514 jyn514 force-pushed the rustdoc-cleanup branch from b916af0 to e23b376 Compare July 14, 2021 01:43
@jyn514
Copy link
Member Author

jyn514 commented Jul 14, 2021

I really hate submodules :( should be fixed now

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514 added 2 commits July 13, 2021 23:38
@jyn514
Remove renaming of test crate
78eae0f 
This is leftover from when `doctest` used to be called `test`. Remove it
now, it's unnecessary and makes the code harder to read.
@jyn514
Remove useless alias from rustc_span to itself
1006175
@jyn514 jyn514 force-pushed the rustdoc-cleanup branch from e23b376 to 1006175 Compare July 14, 2021 03:38
@CraftSpider
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 14, 2021

📌 Commit 1006175 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 14, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2021
@bors
Auto merge of rust-lang#87133 - GuillaumeGomez:rollup-pfz9jbk, r=Guil…
e87188c 
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#87027 (expand: Support helper attributes for built-in derive macros)
 - rust-lang#87056 (Fix codeblocks overflow)
 - rust-lang#87117 (Shrink the CrateStore dynamic interface.)
 - rust-lang#87120 (rustdoc: Remove unnecessary `extern crate` aliases)
 - rust-lang#87125 (Fix Ayu theme `<code>` color)
 - rust-lang#87130 (Update browser-ui-test package version)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e932ba3 into rust-lang:master Jul 14, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 14, 2021
@jyn514 jyn514 deleted the rustdoc-cleanup branch July 15, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CraftSpider CraftSpider

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-highfive @rust-log-analyzer @CraftSpider @bors @rustbot