Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core features cleanup #87768

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Core features cleanup #87768

merged 5 commits into from
Aug 5, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Aug 4, 2021 •
edited
Loading

This sorts and categorizes the #![features] in core and removes unused ones.

This is part of #87766

The following feature attributes were unnecessary and are removed:

// Library features:
-#![feature(bool_to_option)]
-#![feature(char_indices_offset)]
-#![feature(pin_deref_mut)]
-#![feature(str_split_as_str)]
-#![feature(str_split_inclusive_as_str)]

// Language features:
-#![feature(arbitrary_self_types)]
-#![feature(custom_inner_attributes)]
-#![feature(nll)]

@m-ou-se m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2021
@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2021
@m-ou-se m-ou-se mentioned this pull request Aug 4, 2021
Open
8 tasks
dtolnay
dtolnay approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dtolnay
Copy link
Member

dtolnay commented Aug 4, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 4, 2021

📌 Commit 7306c69 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2021
@bors
Copy link
Contributor

bors commented Aug 5, 2021

☔ The latest upstream changes (presumably #86155) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2021
@jyn514
Copy link
Member

jyn514 commented Aug 5, 2021

@bors rollup=iffy

@m-ou-se m-ou-se force-pushed the core-features-cleanup branch from 7306c69 to cdf83c0 Compare August 5, 2021 10:57
@m-ou-se
Copy link
Member Author

m-ou-se commented Aug 5, 2021

Rebased after another PR already removed unwind_attributes attriute.

@bors r=dtolnay

@bors
Copy link
Contributor

bors commented Aug 5, 2021

📌 Commit cdf83c0 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 5, 2021
@bors
Copy link
Contributor

bors commented Aug 5, 2021

⌛ Testing commit cdf83c0 with merge 5caae6edbc5c6a605e585a5b30d5eab6c325c427...

@bors
Copy link
Contributor

bors commented Aug 5, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jyn514
Copy link
Member

jyn514 commented Aug 5, 2021

dist-mingw failed without logs.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2021
@bors
Copy link
Contributor

bors commented Aug 5, 2021

⌛ Testing commit cdf83c0 with merge 2f07ae4...

@bors
Copy link
Contributor

bors commented Aug 5, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 2f07ae4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2021
@bors bors merged commit 2f07ae4 into master Aug 5, 2021
@bors bors deleted the core-features-cleanup branch August 5, 2021 20:37
@rustbot rustbot added this to the 1.56.0 milestone Aug 5, 2021
This was referenced Aug 5, 2021
Closed
Merged
Merged
Merged
Merged
Merged
@dtolnay dtolnay mentioned this pull request Aug 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
7 participants
@m-ou-se @rust-highfive @dtolnay @bors @jyn514 @rust-log-analyzer @rustbot