Rollup of 7 pull requests #88084
Closed
Rollup of 7 pull requests #88084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Cargo deduplicates diagnostics from different targets, this doesn't flood the console with duplicate errors. Note that this doesn't add `--all-targets` in `Builder::cargo` directly because `impl Step for Std` actually wants to omit `--all-targets` the first time while it's still building libtest. When passed `--all-targets`, this warns that the option isn't needed, but still continues to compile.
Also fixed capitalization of documentation
The currently pinned version doesn't compile with the latest rustc nightly
Co-authored-by: Eric Huss <[email protected]> Co-authored-by: inquisitivecrystal <[email protected]> Co-authored-by: Mark Rousskov <[email protected]> Co-authored-by: Daniel Giger <[email protected]>
[rustdoc] Copy only item path to clipboard rather than full `use` statement.
The (somewhat) recent addition of the "copy item import to clipboard" button is extremely nice.
However, i tend to write my code with fully qualified paths wherever feasible and only resort to `use` statements as a refactoring pass. This makes the "copy to clipboard" workflow awkward to use, as i would be copy-pasting that as, say
```rust
impl use std::ops::Add; for MyType {
```
and then go back and remove the `use ` and `;`.
This PR removes the `use ;` decorations, making it much nicer to use for fully-qualified items. I argue, however, that this does not noticeably degrade experience for those who prefer to import items, since the hard part about those is getting the path right, and writing the `use ;` decoration can be done by hand with little effort.
…bini Adding explicit notice of lack of documentation for Tier 2 Platforms Fixing: rust-lang/rustup#2788
…pans, r=cjgillot Detect fake spans in non_fmt_panic lint. This addresses rust-lang#87621 Some proc_macros claim that the user wrote all of the tokens it outputs, by applying a span from the input to all of the produced tokens. That can result in confusing suggestions, as in rust-lang#87621. This is a simple patch that avoids suggesting anything for `panic!("{}")` if the span of `"{}"` and `panic!(..)` are identical, which is normally not possible.
…mulacrum Enable `--all-targets` for `x.py check` unconditionally Now that Cargo deduplicates diagnostics from different targets, this doesn't flood the console with duplicate errors. Note that this doesn't add `--all-targets` in `Builder::cargo` directly because `impl Step for Std` actually wants to omit `--all-targets` the first time while it's still building libtest. When passed `--all-targets`, this warns that the option isn't needed, but still continues to compile. Fixes rust-lang#87846. r? `@Mark-Simulacrum`
Assign FIXMEs to me and remove obsolete ones Also fixed capitalization of documentation We also don't need to transform predicates to be non-const since we basically ignore const predicates in non-const contexts. r? ````@oli-obk````
…-Simulacrum Update redox_syscall The currently pinned version doesn't compile with the latest rustc nightly cc `@jackpot51`
…rk-Simulacrum Update RELEASES.md for 1.55.0 Reopening rust-lang#87624 after some edits and a force-push caused GitHub to close the PR.
|
@bors r+ rollup=never p=7 |
|
📌 Commit 7f8d072 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 7f8d072 with merge 4613828965ff855b275dd5f81fe75f6aaa128d68... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
usestatement. #87178 ([rustdoc] Copy only item path to clipboard rather than fullusestatement.)--all-targetsforx.py checkunconditionally #88011 (Enable--all-targetsforx.py checkunconditionally)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup