addr_of! grants mutable access, maybe?
#90413
Conversation
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@oli-obk @ecstatic-morse to address concerns from #90214 about duplication with |
|
Ah, if that was the only user, then this is perfect! |
compiler/rustc_const_eval/src/transform/check_consts/resolver.rs
Outdated
Show resolved
Hide resolved
|
Impl lgtm r? @RalfJung |
tmiasko
force-pushed
the
addr-of-mutable
branch
from
891ddcf to
cab381f
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit cab381fbddc6e023cab60bcec6dc82b2119faa27 with merge e6aabc9436a8e1ac1d5b98eb99e44b56694506c5... |
|
☀️ Try build successful - checks-actions |
|
Queued e6aabc9436a8e1ac1d5b98eb99e44b56694506c5 with parent 22f1ad7, future comparison URL. |
|
Finished benchmarking commit (e6aabc9436a8e1ac1d5b98eb99e44b56694506c5): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
compiler/rustc_const_eval/src/transform/check_consts/resolver.rs
Outdated
Show resolved
Hide resolved
The exact set of permissions granted when forming a raw reference is currently undecided rust-lang#56604. To avoid presupposing any particular outcome, adjust the const qualification to be compatible with decision where raw reference constructed from `addr_of!` grants mutable access.
tmiasko
force-pushed
the
addr-of-mutable
branch
from
cab381f to
bc4931e
Compare
|
The analysis makes sense to me. The MaybeMutBorrowedLocals removal is code I have never seen but Oli reviewed it, so let's go ahead. @bors r=RalfJung,oli-obk |
|
📌 Commit bc4931e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (baba668): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Implement `clone_from` for `State` Data flow engine uses `clone_from` for domain values. Providing an implementation of `clone_from` will avoid some intermediate memory allocations. Extracted from rust-lang#90413. r? `@oli-obk`
The exact set of permissions granted when forming a raw reference is
currently undecided #56604.
To avoid presupposing any particular outcome, adjust the const
qualification to be compatible with decision where raw reference
constructed from
addr_of!grants mutable access.Additionally, to avoid keeping
MaybeMutBorrowedLocalsin sync withconst qualification, remove it. It's no longer used.
@rust-lang/wg-const-eval