Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Use an empty Vec instead of Option<Vec> #90853

Merged
merged 1 commit into from
Nov 14, 2021
Merged

rustdoc: Use an empty Vec instead of Option<Vec> #90853

merged 1 commit into from
Nov 14, 2021
+7 −13

Conversation

notriddle
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2021
GuillaumeGomez
GuillaumeGomez approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hard to follow but seems like a good improvement in the end.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 13, 2021

📌 Commit 688ed0a has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90853 - notriddle:notriddle/option-vec, r=G…
c35d057 
…uillaumeGomez

rustdoc: Use an empty Vec instead of Option<Vec>
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2021
@bors
Auto merge of rust-lang#90883 - matthiaskrgr:rollup-iu9k5pe, r=matthi…
589ad6a 
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90771 (Fix trait object error code)
 - rust-lang#90840 (relate lifetime in `TypeOutlives` bounds on drop impls)
 - rust-lang#90853 (rustdoc: Use an empty Vec instead of Option<Vec>)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c677a8d into rust-lang:master Nov 14, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 14, 2021
@notriddle notriddle deleted the notriddle/option-vec branch November 14, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
5 participants
@notriddle @rust-highfive @GuillaumeGomez @bors @rustbot