-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ordering traits from OutlivesConstraint
#93089
Conversation
…straint` In two cases where this ordering was used, I've replaced the sorting to use a key that does not include DefId. I'm not sure this is correct in terms of our goals from rust-lang#90317, or otherwise.
(rust-highfive has picked a reviewer for you, use r? to override) |
The passing tests do inspire some confidence here. |
📌 Commit 7f16d0e has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (17dfae7): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
In two cases where this ordering was used, I've replaced the sorting to use a key that does not rely on
DefId
beingOrd
. This is part of #90317. If I understand correctly, whether this is correct depends on whether theRegionVid
s are tracked during incremental compilation. But I might be mistaken in this approach. cc @cjgillot