-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Try using stacker fast path optimization #94099
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 5aea577 with merge 814484750e7788a3b3706831bc6d4f96286f7c3b... |
☀️ Try build successful - checks-actions |
Queued 814484750e7788a3b3706831bc6d4f96286f7c3b with parent 30b3f35, future comparison URL. |
Finished benchmarking commit (814484750e7788a3b3706831bc6d4f96286f7c3b): comparison url. Summary: This benchmark run shows 102 relevant improvements 🎉 but 3 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Closing this as it was an experiment. |
Some stacker optimizations in a private branch (see rust-lang/stacker@master...hkratz:optimize-fast-path) that I want to try with a perf run to see if that is worth pursuing. Assembly and local perf run look promising.
Also includes accepted, but not yet merged #93934.
r? @ghost
@rustbot label S-waiting-on-author