Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Try using stacker fast path optimization #94099

Closed
wants to merge 2 commits into from

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Feb 17, 2022

Some stacker optimizations in a private branch (see rust-lang/stacker@master...hkratz:optimize-fast-path) that I want to try with a perf run to see if that is worth pursuing. Assembly and local perf run look promising.

Also includes accepted, but not yet merged #93934.

r? @ghost
@rustbot label S-waiting-on-author

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2022
@pierwill
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 17, 2022
@bors
Copy link
Contributor

bors commented Feb 17, 2022

⌛ Trying commit 5aea577 with merge 814484750e7788a3b3706831bc6d4f96286f7c3b...

@bors
Copy link
Contributor

bors commented Feb 17, 2022

☀️ Try build successful - checks-actions
Build commit: 814484750e7788a3b3706831bc6d4f96286f7c3b (814484750e7788a3b3706831bc6d4f96286f7c3b)

@rust-timer
Copy link
Collaborator

Queued 814484750e7788a3b3706831bc6d4f96286f7c3b with parent 30b3f35, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (814484750e7788a3b3706831bc6d4f96286f7c3b): comparison url.

Summary: This benchmark run shows 102 relevant improvements 🎉 but 3 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 1.0%
  • Average relevant improvement: -0.4%
  • Largest improvement in instruction counts: -2.9% on incr-patched: add static arr item builds of coercions debug
  • Largest regression in instruction counts: 1.1% on incr-unchanged builds of ctfe-stress-4 check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 18, 2022
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@Dylan-DPC
Copy link
Member

Closing this as it was an experiment.

@Dylan-DPC Dylan-DPC closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants