Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Weak::new const #94991

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Make Weak::new const #94991

merged 1 commit into from
Mar 19, 2022

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Mar 16, 2022 •
edited
Loading

Simple enough. This is const creation of an allocating container, but no actual allocation is done, because it's defined to.

@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2022
@dtolnay dtolnay added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 18, 2022
dtolnay
dtolnay approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks good. Please make a tracking issue.

@CAD97 CAD97 mentioned this pull request Mar 18, 2022
Closed
3 tasks
@CAD97
Copy link
Contributor Author

CAD97 commented Mar 18, 2022

Tracking issue: #95091

@dtolnay dtolnay assigned dtolnay and unassigned m-ou-se Mar 18, 2022
dtolnay
dtolnay approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dtolnay
Copy link
Member

dtolnay commented Mar 18, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 18, 2022

📌 Commit a358ad2 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2022
@bors
Auto merge of rust-lang#95112 - Dylan-DPC:rollup-0jo0loj, r=Dylan-DPC
9c7f6d6 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#93858 (Add a `process_group` method to UNIX `CommandExt`)
 - rust-lang#94650 (Relax tests for Windows dos device names)
 - rust-lang#94991 (Make Weak::new const)
 - rust-lang#95072 (Re-enable parallel debuginfo tests)
 - rust-lang#95109 (Extend --check-cfg tests to all predicate inside all/any)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a73024 into rust-lang:master Mar 19, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 19, 2022
@CAD97 CAD97 deleted the const-weak-new branch March 19, 2022 22:27
@lopopolo lopopolo mentioned this pull request Apr 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CAD97 @rust-highfive @dtolnay @bors @m-ou-se @rustbot