-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make classify_drop_access_kind
iterate
#96359
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue I don't expect perf changes, but let's make sure before rolling up |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a34e1b5 with merge 7f71280f22cfccea406a5595cb1f3504279a0fd1... |
☀️ Try build successful - checks-actions |
Queued 7f71280f22cfccea406a5595cb1f3504279a0fd1 with parent b21759f, future comparison URL. |
Finished benchmarking commit (7f71280f22cfccea406a5595cb1f3504279a0fd1): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. |
@bors r+ rollup Excellent! Thanks for cleaning that up, I totally forgot we added it until your PR removed it |
📌 Commit a34e1b5 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d8e59ed): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. |
This PR:
classify_drop_access_kind
func in the borrowck part. The process of obtainingStorageDeadOrDrop
has been changed from recursive to iterative.place_ty
in each iteration, avoid repeatedly getting thety
of the same place (O(n^2) => O(n))