simplify describe_field func in borrowck's diagnostics part
#96386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jackh726
requested changes
Apr 25, 2022
| let local = &self.body.local_decls[local]; | ||
| self.describe_field_from_ty(local.ty, field, None) | ||
| } | ||
| let place_ty = match place { |
There was a problem hiding this comment.
This could instead just be ty: Ty<_> right? Then in the empty projection case, we don't need to wrap in a PlaceTy?
There was a problem hiding this comment.
I'm guessing you might be talking about PlaceRef? We need to know the value of variant_index, and the structure of PlaceTy fits well. Do you think it is better to separate Ty and variant_index for semantic clarity？
There was a problem hiding this comment.
Whoops I missed the variant index.
|
@bors r+ rollup |
|
📌 Commit 74853ee has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 26, 2022
simplify `describe_field` func in borrowck's diagnostics part This PR simplify the `describe_field` func in borrowck's diagnostics part, besides fix the FIXME in it.
This was referenced Apr 26, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2022
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#94022 (Clarify that `Cow::into_owned` returns owned data) - rust-lang#94703 (Fix codegen bug in "ptx-kernel" abi related to arg passing) - rust-lang#95949 (Implement Default for AssertUnwindSafe) - rust-lang#96361 (Switch JS code to ES6) - rust-lang#96372 (Suggest calling method on nested field when struct is missing method) - rust-lang#96386 (simplify `describe_field` func in borrowck's diagnostics part) - rust-lang#96400 (Correct documentation for `Rvalue::ShallowInitBox`) - rust-lang#96415 (Remove references to git.io) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplify the
describe_fieldfunc in borrowck's diagnostics part, besides fix the FIXME in it.