-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch JS code to ES6 - part 2 #96390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Apr 25, 2022
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Apr 25, 2022
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
es6-part2
branch
from
April 26, 2022 18:59
2033604
to
4e0be6d
Compare
Rebased. :) |
ping :) |
@bors r+ rollup=always |
📌 Commit 4e0be6d has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 29, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96390 (Switch JS code to ES6 - part 2) - rust-lang#96527 (RustWrapper: explicitly don't handle DXILPointerTyID) - rust-lang#96536 (rustdoc: fix missing method list for primitive deref target) - rust-lang#96559 (Use the correct lifetime binder for elided lifetimes in path.) - rust-lang#96560 (Remove unnecessary environment variable in cf-protection documentation) - rust-lang#96562 (Fix duplicate directory separator in --remap-path-prefix.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #93058.
It's based on #96361 so it needs to wait for it to be merged first.
r? @notriddle