Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax memory ordering used in SameMutexCheck #96619

Merged
merged 3 commits into from May 5, 2022
Merged

Relax memory ordering used in SameMutexCheck #96619

merged 3 commits into from May 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2022

SameMutexCheck only requires atomicity for self.addr, but does not need ordering of other memory accesses in either the success or failure case. Using Relaxed, the code still correctly handles the case when two threads race to store an address.

Relax memory ordering used in SameMutexCheck
df4457e 
`SameMutexCheck` only requires atomicity for `self.addr`, but does not need ordering of other memory accesses in either the success or failure case. Using `Relaxed`, the code still correctly handles the case when two threads race to store an address.
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 1, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2022
@ghost
Copy link
Author

ghost commented May 1, 2022

r? @joshtriplett

@rust-highfive rust-highfive assigned joshtriplett and unassigned thomcc May 1, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented May 2, 2022 •
edited
Loading

Oh, I was unassigned as the reviewer. Still, I'd like a comment for this. Looks good to me now.

Austin Kiekintveld added 2 commits May 1, 2022 19:02
@ghost ghost requested a review from thomcc May 2, 2022 02:08
thomcc
thomcc approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I'll let @joshtriplett review since you explicitly requested it, though.

@joshtriplett joshtriplett requested a review from m-ou-se May 2, 2022 07:01
@joshtriplett
Copy link
Member

This LGTM, but requesting a review from @m-ou-se who has been working extensively on the mutex code lately.

@m-ou-se
Copy link
Member

m-ou-se commented May 2, 2022

@bors r+

Note that this code will be deleted Soon:tm:, when we get rid of boxed locks on all platforms. :)

@bors
Copy link
Contributor

bors commented May 2, 2022

📌 Commit 55a7d18 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2022
@JohnTitor JohnTitor mentioned this pull request May 5, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2022
@bors
Auto merge of rust-lang#96720 - JohnTitor:rollup-9jaaekr, r=JohnTitor
7d3e036 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#96603 (Enable full revision in const generics ui tests)
 - rust-lang#96616 (Relax memory ordering used in `min_stack`)
 - rust-lang#96619 (Relax memory ordering used in SameMutexCheck)
 - rust-lang#96628 (Stabilize `bool::then_some`)
 - rust-lang#96658 (Move callback to the () => {} syntax.)
 - rust-lang#96677 (Add more tests for label-break-value)
 - rust-lang#96697 (Enable tracing for all queries)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b792258 into rust-lang:master May 5, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se Awaiting requested review from m-ou-se

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rust-highfive @rust-log-analyzer @thomcc @joshtriplett @m-ou-se @bors @rustbot