Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Try custom index types for indexmap #96751

Closed
wants to merge 1 commit into from

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 6, 2022

Looking for real-world results on indexmap-rs/indexmap#147.

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2022
@cuviper
Copy link
Member Author

cuviper commented May 6, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 6, 2022
@bors
Copy link
Contributor

bors commented May 6, 2022

⌛ Trying commit 570bbc5 with merge bfca2502fef9bf25cd9fd78f452f800447ad46ef...

@bors
Copy link
Contributor

bors commented May 6, 2022

☀️ Try build successful - checks-actions
Build commit: bfca2502fef9bf25cd9fd78f452f800447ad46ef (bfca2502fef9bf25cd9fd78f452f800447ad46ef)

@rust-timer
Copy link
Collaborator

Queued bfca2502fef9bf25cd9fd78f452f800447ad46ef with parent 30f3860, future comparison URL.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking petgraph v0.5.1
    Checking gimli v0.26.1
    Checking object v0.28.1
    Checking tempfile v3.2.0
    Checking indexmap v2.0.0-pre (https://github.com/cuviper/indexmap?branch=indexable#3b6d807f)
    Checking synstructure v0.12.6
    Checking rustc_macros v0.1.0 (/checkout/compiler/rustc_macros)
   Compiling tracing-attributes v0.1.18
   Compiling unic-langid-macros-impl v0.9.0
---
configure: rust.debug-assertions := True
configure: rust.overflow-checks := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
    Checking unic-ucd-version v0.9.0
   Compiling generic-array v0.14.4
   Compiling ahash v0.7.4
   Compiling unic-langid-impl v0.9.0
    Checking indexmap v2.0.0-pre (https://github.com/cuviper/indexmap?branch=indexable#3b6d807f)
    Checking thread_local v1.1.4
    Checking miniz_oxide v0.4.0
    Checking unicode-normalization v0.1.13
    Checking expect-test v1.0.1
---
   Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
    Finished release [optimized] target(s) in 6.94s
tidy check
tidy: Skipping binary file check, read-only filesystem
tidy error: invalid source: "git+https://github.com/cuviper/indexmap?branch=indexable#3b6d807f460308e6de30cd34f9516aca624615f2"
* 629 error codes
* highest error code: E0787
Found 504 error codes
Found 0 error(s) in error codes

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bfca2502fef9bf25cd9fd78f452f800447ad46ef): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 1 10 9 10
mean2 N/A 1.7% -0.5% -0.5% -0.5%
max N/A 1.7% -0.7% -0.6% -0.7%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 6, 2022
@cuviper cuviper closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants