mir relate: we don't need needs_wf #97890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
lcnr
commented
Jun 29, 2022
| /// We could deal with this by checking all types we end up relating | ||
| /// for well-formedness. Or at least all types that matter... | ||
| /// | ||
| /// Alternatively, lazily can check whether we encounter a bivariant |
There was a problem hiding this comment.
Suggested change
| /// Alternatively, lazily can check whether we encounter a bivariant | |
| /// Alternatively, we can lazily check whether we encounter a bivariant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54105
Should still think about higher ranked equality which currently relies on mutual subtyping.
All other subtyping in the MIR either is fine as both sides are checked for WF or them not being WF is irrelevant. Any type mentioned in the MIR whose the lack of WF checks is an issue probably should get one, regardless of whether we add
needs_wfto theTypeGeneralizer.r? @nikomatsakis cc @rust-lang/wg-nll