Use less string interning #98638

bjorn3 · 2022-06-28T18:40:09Z

This removes string interning in a couple of places where doing so won't result in perf improvements. I also switched one place to use pre-interned symbols.

Interning here doesn't save us anything. It rather costs a bit of time.

rustbot · 2022-06-28T18:40:13Z

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

rust-highfive · 2022-06-28T18:40:13Z

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2022-06-28T18:43:45Z

@bors try @rust-timer queue

rust-timer · 2022-06-28T18:43:47Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-28T18:43:54Z

⌛ Trying commit 566bb8d5a574df9b6814ee85a4bc22c61b85ef5d with merge 50ddf6d97cca693466234951f314e347574e0255...

bors · 2022-06-28T20:34:23Z

☀️ Try build successful - checks-actions
Build commit: 50ddf6d97cca693466234951f314e347574e0255 (50ddf6d97cca693466234951f314e347574e0255)

rust-timer · 2022-06-28T20:34:25Z

Queued 50ddf6d97cca693466234951f314e347574e0255 with parent 94e9374, future comparison URL.

rust-timer · 2022-06-29T05:57:35Z

Finished benchmarking commit (50ddf6d97cca693466234951f314e347574e0255): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.0%	3.7%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.1%	-3.7%	3
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.0%	4.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.9%	-2.9%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

compiler/rustc_typeck/src/check/intrinsic.rs

tmiasko · 2022-07-05T13:32:14Z

Thanks, r=me with or without addressing the nit.

bjorn3 · 2022-07-05T14:33:50Z

@bors r=tmiasko

bors · 2022-07-05T14:33:52Z

📌 Commit f688f4d has been approved by tmiasko

bors · 2022-07-07T03:58:32Z

⌛ Testing commit f688f4d with merge 2808ff66b08f8095a220aa2c7c733857803be5b2...

rust-log-analyzer · 2022-07-07T04:17:34Z

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


---- [ui] src/test/ui/invalid/invalid-llvm-passes.rs stdout ----
diff of stderr:

1 error: failed to run LLVM passes: unknown pass name 'unknown-pass'
+ thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
+   left: `LLVMing`,
+   left: `LLVMing`,
+  right: `Codegenning`', $COMPILER_DIR/rustc_codegen_ssa/src/back/write.rs:1467:21
+    0:     0x7f1d09983000 - std::backtrace_rs::backtrace::libunwind::trace::h8414809a63f785cb
+                                at $SRC_DIR/std/src/../../backtrace/src/backtrace/mod.rs:LL:COL
+    1:     0x7f1d09983000 - std::backtrace_rs::backtrace::trace_unsynchronized::hbb276a73b2551f27
+                                at $SRC_DIR/std/src/../../backtrace/src/backtrace/mod.rs:LL:COL
+                                at $SRC_DIR/std/src/../../backtrace/src/backtrace/mod.rs:LL:COL
+    2:     0x7f1d09983000 - std::sys_common::backtrace::_print_fmt::hc58d84a65520ee78
+                                at $SRC_DIR/std/src/sys_common/backtrace.rs:LL:COL
+    3:     0x7f1d09983000 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf411b81d23da6379
+                                at $SRC_DIR/std/src/sys_common/backtrace.rs:LL:COL
+    4:     0x7f1d099dbcbc - core::fmt::write::hc9390b9d841fadfb
+                                at $SRC_DIR/core/src/fmt/mod.rs:LL:COL
+    5:     0x7f1d099748a5 - std::io::Write::write_fmt::hbf6048e30fe00cee
+                                at $SRC_DIR/std/src/io/mod.rs:LL:COL
+    6:     0x7f1d09985bf1 - std::sys_common::backtrace::_print::heb93f7770ccc092a
+                                at $SRC_DIR/std/src/sys_common/backtrace.rs:LL:COL
+    7:     0x7f1d09985bf1 - std::sys_common::backtrace::print::h49cd50d46dcdabd1
+                                at $SRC_DIR/std/src/sys_common/backtrace.rs:LL:COL
+    8:     0x7f1d09985bf1 - std::panicking::default_hook::{{closure}}::h2065e6b06787531a
+                                at $SRC_DIR/std/src/panicking.rs:LL:COL
+    9:     0x7f1d099858c3 - std::panicking::default_hook::hf4e733c3b40ff74a
+                                at $SRC_DIR/std/src/panicking.rs:LL:COL
+   10:     0x7f1d0a874bf6 - rustc_driver[7715d818b6b0e8df]::DEFAULT_HOOK::{closure#0}::{closure#0}
+   11:     0x7f1d099863c6 - std::panicking::rust_panic_with_hook::h7a01ba63a552e65b
+                                at $SRC_DIR/std/src/panicking.rs:LL:COL
+   12:     0x7f1d09986217 - std::panicking::begin_panic_handler::{{closure}}::h4f918d6844b6b067
+                                at $SRC_DIR/std/src/panicking.rs:LL:COL
+   13:     0x7f1d099834d4 - std::sys_common::backtrace::__rust_end_short_backtrace::hd208f629f3092398
+                                at $SRC_DIR/std/src/sys_common/backtrace.rs:LL:COL
+   14:     0x7f1d09985f42 - rust_begin_unwind
+                                at $SRC_DIR/std/src/panicking.rs:LL:COL
+   15:     0x7f1d0994ae03 - core::panicking::panic_fmt::hccbb92404164eb30
+                                at $SRC_DIR/core/src/panicking.rs:LL:COL
+   16:     0x7f1d099d8a18 - core::panicking::assert_failed_inner::h54d35828061e4a63
+   17:     0x7f1d0a57095b - core[e8f8ec297493aa9f]::panicking::assert_failed::<rustc_codegen_ssa[54c10ff5414869a7]::back::write::MainThreadWorkerState, rustc_codegen_ssa[54c10ff5414869a7]::back::write::MainThreadWorkerState>
+   18:     0x7f1d0ab48aad - std[74e7685dc83ab0f4]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend as rustc_codegen_ssa[54c10ff5414869a7]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[54c10ff5414869a7]::back::write::start_executing_work<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend>::{closure#4}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#0}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>
+   19:     0x7f1d0aaeefa9 - <<std[74e7685dc83ab0f4]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend as rustc_codegen_ssa[54c10ff5414869a7]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[54c10ff5414869a7]::back::write::start_executing_work<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend>::{closure#4}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#0}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#1} as core[e8f8ec297493aa9f]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
+   20:     0x7f1d0998fd23 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h1b33063481ea261e
+                                at $SRC_DIR/alloc/src/boxed.rs:LL:COL
+   21:     0x7f1d0998fd23 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h492c0b3808aa6969
+                                at $SRC_DIR/alloc/src/boxed.rs:LL:COL
+   22:     0x7f1d0998fd23 - std::sys::unix::thread::Thread::new::thread_start::h752f1da4a10216bc
+                                at $SRC_DIR/std/src/sys/unix/thread.rs:LL:COL
+   23:     0x7f1d08ef96ba - start_thread
+   24:     0x7f1d0962251d - clone
+   25:                0x0 - <unknown>
+ error: internal compiler error: unexpected panic
+ 
+ note: the compiler unexpectedly panicked. this is a bug.
+ 
+ 
+ note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
+ 
+ note: rustc 1.64.0-nightly (2808ff66b 2022-07-07) running on x86_64-unknown-linux-gnu
+ 
+ note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C linker=cc -C passes=unknown-pass -Z new-llvm-pass-manager=yes
+ query stack during panic:
+ end of query stack
3 error: aborting due to previous error
4 
---
To only update this specific test, also pass `--test-args invalid/invalid-llvm-passes.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/invalid/invalid-llvm-passes.rs" "-Zthreads=1" "--target=i586-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i586-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=cc" "-Cpasses=unknown-pass" "-Z" "new-llvm-pass-manager=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/invalid/invalid-llvm-passes/auxiliary"
stdout: none
--- stderr -------------------------------
error: failed to run LLVM passes: unknown pass name 'unknown-pass'
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `LLVMing`,
  left: `LLVMing`,
 right: `Codegenning`', /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/compiler/rustc_codegen_ssa/src/back/write.rs:1467:21
   0:     0x7f1d09983000 - std::backtrace_rs::backtrace::libunwind::trace::h8414809a63f785cb
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   1:     0x7f1d09983000 - std::backtrace_rs::backtrace::trace_unsynchronized::hbb276a73b2551f27
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x7f1d09983000 - std::sys_common::backtrace::_print_fmt::hc58d84a65520ee78
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys_common/backtrace.rs:66:5
   3:     0x7f1d09983000 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf411b81d23da6379
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys_common/backtrace.rs:45:22
   4:     0x7f1d099dbcbc - core::fmt::write::hc9390b9d841fadfb
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/core/src/fmt/mod.rs:1198:17
   5:     0x7f1d099748a5 - std::io::Write::write_fmt::hbf6048e30fe00cee
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/io/mod.rs:1672:15
   6:     0x7f1d09985bf1 - std::sys_common::backtrace::_print::heb93f7770ccc092a
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys_common/backtrace.rs:48:5
   7:     0x7f1d09985bf1 - std::sys_common::backtrace::print::h49cd50d46dcdabd1
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys_common/backtrace.rs:35:9
   8:     0x7f1d09985bf1 - std::panicking::default_hook::{{closure}}::h2065e6b06787531a
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/panicking.rs:295:22
   9:     0x7f1d099858c3 - std::panicking::default_hook::hf4e733c3b40ff74a
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/panicking.rs:314:9
  10:     0x7f1d0a874bf6 - rustc_driver[7715d818b6b0e8df]::DEFAULT_HOOK::{closure#0}::{closure#0}
  11:     0x7f1d099863c6 - std::panicking::rust_panic_with_hook::h7a01ba63a552e65b
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/panicking.rs:702:17
  12:     0x7f1d09986217 - std::panicking::begin_panic_handler::{{closure}}::h4f918d6844b6b067
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/panicking.rs:588:13
  13:     0x7f1d099834d4 - std::sys_common::backtrace::__rust_end_short_backtrace::hd208f629f3092398
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys_common/backtrace.rs:138:18
  14:     0x7f1d09985f42 - rust_begin_unwind
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/panicking.rs:584:5
  15:     0x7f1d0994ae03 - core::panicking::panic_fmt::hccbb92404164eb30
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/core/src/panicking.rs:142:14
  16:     0x7f1d099d8a18 - core::panicking::assert_failed_inner::h54d35828061e4a63
  17:     0x7f1d0a57095b - core[e8f8ec297493aa9f]::panicking::assert_failed::<rustc_codegen_ssa[54c10ff5414869a7]::back::write::MainThreadWorkerState, rustc_codegen_ssa[54c10ff5414869a7]::back::write::MainThreadWorkerState>
  18:     0x7f1d0ab48aad - std[74e7685dc83ab0f4]::sys_common::backtrace::__rust_begin_short_backtrace::<<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend as rustc_codegen_ssa[54c10ff5414869a7]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[54c10ff5414869a7]::back::write::start_executing_work<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend>::{closure#4}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#0}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>
  19:     0x7f1d0aaeefa9 - <<std[74e7685dc83ab0f4]::thread::Builder>::spawn_unchecked_<<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend as rustc_codegen_ssa[54c10ff5414869a7]::traits::backend::ExtraBackendMethods>::spawn_thread<rustc_codegen_ssa[54c10ff5414869a7]::back::write::start_executing_work<rustc_codegen_llvm[fd2cbb62e2ac9eef]::LlvmCodegenBackend>::{closure#4}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#0}, core[e8f8ec297493aa9f]::result::Result<rustc_codegen_ssa[54c10ff5414869a7]::back::write::CompiledModules, ()>>::{closure#1} as core[e8f8ec297493aa9f]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  20:     0x7f1d0998fd23 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h1b33063481ea261e
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/alloc/src/boxed.rs:1934:9
  21:     0x7f1d0998fd23 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h492c0b3808aa6969
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/alloc/src/boxed.rs:1934:9
  22:     0x7f1d0998fd23 - std::sys::unix::thread::Thread::new::thread_start::h752f1da4a10216bc
                               at /rustc/2808ff66b08f8095a220aa2c7c733857803be5b2/library/std/src/sys/unix/thread.rs:108:17
  23:     0x7f1d08ef96ba - start_thread
  24:     0x7f1d0962251d - clone
  25:                0x0 - <unknown>
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.


note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.64.0-nightly (2808ff66b 2022-07-07) running on x86_64-unknown-linux-gnu

note: compiler flags: -Z threads=1 -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C linker=cc -C passes=unknown-pass -Z new-llvm-pass-manager=yes
query stack during panic:
end of query stack
error: aborting due to previous error
------------------------------------------

bors · 2022-07-07T04:18:42Z

💔 Test failed - checks-actions

tmiasko · 2022-07-08T08:40:34Z

@bors retry #95679

bors · 2022-07-08T10:03:30Z

⌛ Testing commit f688f4d with merge 1dcff2d...

bors · 2022-07-08T12:44:08Z

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 1dcff2d to master...

rust-timer · 2022-07-08T18:30:24Z

Finished benchmarking commit (1dcff2d): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.2%	1.2%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-1.4%	-2.3%	10
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	0.6%	1.2%	2
Regressions 😿 (secondary)	2.2%	2.2%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.1%	-4.3%	4
All 😿🎉 (primary)	0.6%	1.2%	2

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	3.3%	3.3%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.4%	-4.3%	7
All 😿🎉 (primary)	3.3%	3.3%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Use less string interning This removes string interning in a couple of places where doing so won't result in perf improvements. I also switched one place to use pre-interned symbols.

bjorn3 added 3 commits June 28, 2022 18:38

Avoid unnecessary string interning for const_str

f6484fa

Use pre-interned symbols in import recovery

de57dbc

Reduce usage of Symbol in the linker code

f688f4d

Interning here doesn't save us anything. It rather costs a bit of time.

rust-highfive assigned jackh726 Jun 28, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 28, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 29, 2022

tmiasko reviewed Jul 5, 2022

View reviewed changes

compiler/rustc_typeck/src/check/intrinsic.rs Outdated Show resolved Hide resolved

bjorn3 force-pushed the less_string_interning branch from 566bb8d to f688f4d Compare July 5, 2022 14:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2022

RalfJung mentioned this pull request Jul 6, 2022

Rollup of 5 pull requests #98970

Merged

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 7, 2022

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2022

bors merged commit 1dcff2d into rust-lang:master Jul 8, 2022

rustbot added this to the 1.64.0 milestone Jul 8, 2022

This was referenced Jul 8, 2022

don't allow ZST in ScalarInt #98957

Merged

interpret: get rid of MemPlaceMeta::Poison #99013

Merged

bjorn3 deleted the less_string_interning branch July 8, 2022 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use less string interning #98638

Use less string interning #98638

bjorn3 commented Jun 28, 2022

rustbot commented Jun 28, 2022

rust-highfive commented Jun 28, 2022

bjorn3 commented Jun 28, 2022

rust-timer commented Jun 28, 2022

bors commented Jun 28, 2022

bors commented Jun 28, 2022

rust-timer commented Jun 28, 2022

rust-timer commented Jun 29, 2022

tmiasko commented Jul 5, 2022

bjorn3 commented Jul 5, 2022

bors commented Jul 5, 2022

bors commented Jul 7, 2022

rust-log-analyzer commented Jul 7, 2022

bors commented Jul 7, 2022

tmiasko commented Jul 8, 2022

bors commented Jul 8, 2022

bors commented Jul 8, 2022

rust-timer commented Jul 8, 2022

Use less string interning #98638

Use less string interning #98638

Conversation

bjorn3 commented Jun 28, 2022

rustbot commented Jun 28, 2022

rust-highfive commented Jun 28, 2022

bjorn3 commented Jun 28, 2022

rust-timer commented Jun 28, 2022

bors commented Jun 28, 2022

bors commented Jun 28, 2022

rust-timer commented Jun 28, 2022

rust-timer commented Jun 29, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

tmiasko commented Jul 5, 2022

bjorn3 commented Jul 5, 2022

bors commented Jul 5, 2022

bors commented Jul 7, 2022

rust-log-analyzer commented Jul 7, 2022

bors commented Jul 7, 2022

tmiasko commented Jul 8, 2022

bors commented Jul 8, 2022

bors commented Jul 8, 2022

rust-timer commented Jul 8, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes