Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #95993 fix #98731

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Revert #95993 fix #98731

merged 1 commit into from
Jul 4, 2022

Conversation

b-ncMN
Copy link
Contributor

@b-ncMN b-ncMN commented Jun 30, 2022

This reverts the temporary fix implemented by #95993 since a permanent fix has been implemented by rust-lang/cargo#10594

Fixes #98728

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2022
This reverts the temporary fix implemented by rust-lang#95993 since a permanent fix has been implemented by rust-lang/cargo#10594
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jul 2, 2022

📌 Commit 81b525e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 3, 2022

@InfRandomness can you confirm that you've tested x test --doc --stage 0 library/std locally and it works ok?

@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 3, 2022

x test --doc --stage 0 library/std

running 1210 tests
i....................................................................................... 88/1210
........................................................................................ 176/1210
........................................................................................ 264/1210
........................................................................................ 352/1210
...................................i.i.................................................. 440/1210
..............................i....i.................................................... 528/1210
............i...........ii.............................................................. 616/1210
........................................................................................ 704/1210
........................................................................................ 792/1210
........................................................................................ 880/1210
...........................................................................ii.i......... 968/1210
........................................................................................ 1056/1210
.....................................................................iiiiii............. 1144/1210
..................................i...............................
test result: ok. 1192 passed; 0 failed; 18 ignored; 0 measured; 0 filtered out; finished in 24.57s

	finished in 25.970 seconds
warning: you have not made a `config.toml`
help: consider running `./x.py setup` or copying `config.toml.example` by running `cp config.toml.example config.toml`
note: this message was printed twice to make it more likely to be seen
Build completed successfully in 0:01:28

@bors
Copy link
Contributor

bors commented Jul 4, 2022

⌛ Testing commit 81b525e with merge a5c6a48...

@bors
Copy link
Contributor

bors commented Jul 4, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a5c6a48 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2022
@bors bors merged commit a5c6a48 into rust-lang:master Jul 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 4, 2022
@b-ncMN b-ncMN deleted the fix-#98728 branch July 4, 2022 06:39
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a5c6a48): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
1.2% 1.4% 2
Regressions 😿
(secondary)
2.9% 3.3% 6
Improvements 🎉
(primary)
-0.6% -0.9% 11
Improvements 🎉
(secondary)
-1.4% -2.3% 12
All 😿🎉 (primary) -0.3% 1.4% 13

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-2.7% -3.1% 2
Improvements 🎉
(secondary)
-1.9% -2.0% 2
All 😿🎉 (primary) -2.7% -3.1% 2

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-3.2% -4.5% 9
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added the perf-regression Performance regression. label Jul 4, 2022
@b-ncMN
Copy link
Contributor Author

b-ncMN commented Jul 4, 2022

I'm not sure why this would cause a regression, should we be worried about it ?

@jyn514
Copy link
Member

jyn514 commented Jul 4, 2022

Nah, perf has been noisy lately, I think it's fine.

@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Jul 5, 2022
@Mark-Simulacrum
Copy link
Member

I think these particular benchmarks are indeed a little noisier over the last week or so, so dropping regression label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hack for test --stage 0 --doc std
7 participants