-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #95993 fix #98731
Revert #95993 fix #98731
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This reverts the temporary fix implemented by rust-lang#95993 since a permanent fix has been implemented by rust-lang/cargo#10594
@bors r+ rollup=iffy |
📌 Commit 81b525e has been approved by |
@InfRandomness can you confirm that you've tested |
|
☀️ Test successful - checks-actions |
Finished benchmarking commit (a5c6a48): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
I'm not sure why this would cause a regression, should we be worried about it ? |
Nah, perf has been noisy lately, I think it's fine. |
I think these particular benchmarks are indeed a little noisier over the last week or so, so dropping regression label. |
This reverts the temporary fix implemented by #95993 since a permanent fix has been implemented by rust-lang/cargo#10594
Fixes #98728