handle consts with param/infer in const_eval_resolve better
#99618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred in const_evaluatable.rs cc @lcnr Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Jul 22, 2022
lcnr
reviewed
Jul 25, 2022
lcnr
reviewed
Jul 25, 2022
|
2 nits, then r=me thanks ❤️ |
|
@lcnr can you take one last look at this? addressed the nits in the last commit, but I didn't know what to do when we had a |
lcnr
reviewed
Jul 26, 2022
| if ct.has_infer_types_or_consts() || ct.has_param_types_or_consts() => | ||
| { | ||
| let mut ty = ct.ty(); | ||
| // If the type references param or infer, replace that too... |
There was a problem hiding this comment.
that should be unreachable, so you should be able to bug! there
inference variables in the type of ty::Const is something we can't deal with right now, so if we encounter them either:
- something went wrong and we should ICE
- my understanding of const generics is flawed, so i also want to know about that
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 26, 2022
handle consts with param/infer in `const_eval_resolve` better This PR addresses [this thread here](rust-lang#99449 (comment)). Was this the change you were looking for `@lcnr?` Interestingly, one test has begun to pass. Was that expected? r? `@lcnr`
This was referenced Jul 26, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 26, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#99618 (handle consts with param/infer in `const_eval_resolve` better) - rust-lang#99666 (Restore `Opaque` behavior to coherence check) - rust-lang#99692 (interpret, ptr_offset_from: refactor and test too-far-apart check) - rust-lang#99739 (Remove erroneous E0133 code from an error message.) - rust-lang#99748 (Use full type name instead of just saying `impl Trait` in "captures lifetime" error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this thread here. Was this the change you were looking for @lcnr?
Interestingly, one test has begun to pass. Was that expected?
r? @lcnr