-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite bootstrapping stages #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if a complete rewrite is a good idea. At the very least, it'll probably be a while until this is reviewed since it's such a big change.
fe8583d
to
beb68df
Compare
Alright, I feel I made it more readable in general. And I don't feel I missed anything. I feel it's a step forward all things considered. I don't feel anything important has been removed.
It seemed to warrant a rewrite, as I was reading it. So that's what I did. Here's a suggested workflow for reviewing this:
Each item should be explained at least well enough. That is, if it is relevant at all. |
beb68df
to
cbc46e4
Compare
We've discussed this on the Zulip, and we're going not to merge this as we don't think this doesn't seem to have much improvement. Thanks for proposing changes anyway! |
It was written carefully. I'm certain that it's a significant improvement. |
Could you elaborate on what improvements your changes are bringing? I'm not an English native and it's a bit unclear how these changes improve stuff. |
I just updated this branch yet cannot see that update here. Perhaps re-open? |
No description provided.