Add lowering rules for GATs #147
Conversation
tmandry
force-pushed
the
gat-lowering-rules
branch
from
67f1414 to
d8d13a8
Compare
src/traits-lowering-rules.md
Outdated
| // XXX how exactly should we set this up? Have to be careful; | ||
| // presumably this has to be a kind of `FromEnv` setup. | ||
| // Rule Implied-Bound-From-AssocTy | ||
| forall<Self, P1..Pn, Pn+1..Pm> { |
There was a problem hiding this comment.
Could you add: « for each Bound in the set of Bounds » or something like this, to emphasize the fact that we output one FromEnv rule at a time
src/traits-lowering-rules.md
Outdated
|
|
||
| ```text | ||
| // Rule Normalize-From-Impl | ||
| forall<P0..Pm> { | ||
| forall<Pn+1..Pm> { | ||
| Normalize(<A0 as Trait<A1..An>>::AssocType<Pn+1..Pm> -> T) :- | ||
| WC && WC1 | ||
| WC_impl && WC1 |
There was a problem hiding this comment.
WC_impl can actually be replaced with Implemented(A0: Trait) (and that’s what we do in chalk)
There was a problem hiding this comment.
Done. Do you think it's more or less confusing to keep WC_impl around then? :)
There was a problem hiding this comment.
Let’s keep it, so that it looks like a general enough impl.
There was a problem hiding this comment.
Moreover, your comment just below about what the impl can rely on is very informative.
There was a problem hiding this comment.
Sounds good. I added a note about WC_impl being unused just so it doesn't seem like a mistake.
tmandry
force-pushed
the
gat-lowering-rules
branch
from
d8d13a8 to
80e9918
Compare
tmandry
force-pushed
the
gat-lowering-rules
branch
from
80e9918 to
8a98e39
Compare
Add the lowering rules from rust-lang/chalk#12 (comment) that were added to Chalk in rust-lang/chalk#134.
cc #137, @scalexm, @nikomatsakis