Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incremental-compilation-in-detail.md #1553

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Update incremental-compilation-in-detail.md #1553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8d345
Update incremental-compilation-in-detail.md
gftea Jan 11, 2023
07ffbb4
Update src/queries/incremental-compilation-in-detail.md
gftea Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/queries/incremental-compilation-in-detail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ the result of `type_of(bar)` might yield a different result than what we
have in the cache and, transitively, the result of `type_check_item(foo)`
might have changed too. We thus re-run `type_check_item(foo)`, which in
turn will re-run `type_of(bar)`, which will yield an up-to-date result
because it reads the up-to-date version of `Hir(bar)`.
because it reads the up-to-date version of `Hir(bar)`. Also, we re-run
`type_check_item(bar)` because result of `type_of(bar)` might have changed.


## The Problem With The Basic Algorithm: False Positives
Expand Down