Updated instructions for tracking issue #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed link to Forge instructions for documentation since they no longer seem to exist.
|
I think it'd be nice to add links to rustc-guide instead like this rust-lang/rust#65262 (comment) |
|
There's no section in the Rustc guide about writing documentation, last time I checked. |
|
Uhmm? IMO, it's enough to add the link to here as above. |
|
Oh, that's useful yes, but it should probably be linked in the previous bullet point ( |
|
This is ideal for me, what about? - [ ] Implement the RFC (cc @rust-lang/compiler -- can anyone write up mentoring
instructions?)
- [ ] Adjust documentation ([see instructions on rustc-guide](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#documentation-prs))
- [ ] Stabilization PR ([see instructions on rustc-guide](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#stabilization-pr)) |
|
@JohnTitor Yep, I've updated to that with just minor wording/punctuation differences. Should be good to merge now. |
JohnTitor
approved these changes
Nov 1, 2019
|
Cheers. |
mark-i-m
pushed a commit
to spastorino/rustc-dev-guide
that referenced
this pull request
Jan 2, 2020
* Updated instructions for tracking issue Removed link to Forge instructions for documentation since they no longer seem to exist. * Improved links and wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed link to Forge instructions for documentation since they no longer seem to exist.