Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update measureme to latest stable release #1779

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

lqd
Copy link
Member

@lqd lqd commented Dec 19, 2023

This PR updates the site's use of measureme to version 11.0.0 with its new 64bit-indices format. It also switches to using the stable branch instead of the master branch, as requested by wg-self-profile.

I tried to test this locally, but didn't manage to. I myself don't know of a way to bypass needing S3 transfers of the profdata files.

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll test it in production!

@Kobzol
Copy link
Contributor

Kobzol commented Dec 20, 2023

I'm planning to rip the invocation of summarize out of rustc-fake, move it to collector and replace the summarize binary invocation with just using the analyzeme crate in collector, to improve the current behavior. This doesn't have to block this PR though.

@Kobzol
Copy link
Contributor

Kobzol commented Dec 23, 2023

It seems to be working fine locally.

@Kobzol Kobzol merged commit afc63d7 into rust-lang:master Dec 23, 2023
11 checks passed
@lqd lqd deleted the measuremeup branch December 23, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants