-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the TLV public and a pointer for provenance reasons #10
Conversation
… stock rayon-core
Do you have a rustc branch to show the improvement there? |
Not yet. |
Hmm, I see how this makes it easier for I recently released new versions of |
Sure. Are you volunteering me? |
It was a suggestion to gauge interest, especially since you've expressed a preference for this fork to have a clean commit-per-feature history over upstream rayon. Here, I'll meet you partway: rayon-rs/rayon@master...cuviper:rayon:rustc-0.5 Please check that I didn't mess that up... then would you like to revamp the TLV patch in that series? If so, feel free to rebase/rewrite the commit series as you see fit. |
I merged the commits and included this PR. Here's the branch. I also tested that rustc still works with it and looked over the commits. |
4b5faff
to
f192a48
Compare
Thanks! I further tweaked this to add |
Yeah, that looks fine. |
Published, should be all set! |
Use Rayon's TLV directly This accesses Rayon's `TLV` thread local directly avoiding wrapper functions. This makes rustc work with rust-lang/rustc-rayon#10. r? `@cuviper`
Use Rayon's TLV directly This accesses Rayon's `TLV` thread local directly avoiding wrapper functions. This makes rustc work with rust-lang/rustc-rayon#10. r? `@cuviper`
Making the TLV public simplifies the conditional logic in
rustc
. It also uses the new fasterconst
thread locals.