Use a BufWriter in emit_module to reduce syscall overhead #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the coercions rustc-perf benchmark without this commit reduces the total amount of time it takes to emit the object file from 270ms to 27ms.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 9, 2024
…orn3 Subtree sync for rustc_codegen_cranelift Apart from a perf optimization for some crates (rust-lang/rustc_codegen_cranelift#1541) not much changed this time as the last sync was less than a week ago. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…orn3 Subtree sync for rustc_codegen_cranelift Apart from a perf optimization for some crates (rust-lang/rustc_codegen_cranelift#1541) not much changed this time as the last sync was less than a week ago. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the coercions rustc-perf benchmark without this commit reduces the total amount of time it takes to emit the object file from 270ms to 27ms.