-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object::write as alternative object file writer #758
Conversation
Sorry I haven't had time to finish this off. Let me know if I can do anything to help debug the osx failure. |
No problem. The macOS failure is not caused by this. It fails on master too: https://github.com/bjorn3/rustc_codegen_cranelift/issues/728. Upstream issue: rust-lang/rust#64872. |
@philipc Do you want to review this PR before I merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
I tried testing this for Windows but something unrelated to this PR has changed and I'm getting errors when linking:
note: LINK : fatal error LNK1181: cannot open input file 'c.lib'
Thanks for testing. Disclaimer: I have never used a compiler on Windows. It seems to me that the linker couldn't find libc. |
It should be exported from the generated dylib
|
I think I know. It is |
Thanks, yep that's what it is. I don't even remember doing that change. There's other changes needed too. I'll work on a PR for Windows once this is merged. |
Based on philipc@3db2996 by @philipc.
TODO