Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-fmt should format tests by default #803

Closed
kamalmarhubi opened this issue Feb 2, 2016 · 5 comments
Closed

cargo-fmt should format tests by default #803

kamalmarhubi opened this issue Feb 2, 2016 · 5 comments

Comments

@kamalmarhubi
Copy link
Contributor

Right now it'll only format the library and binary. You have to run rustfmt on the test source files directly to get tests.
@kamalmarhubi kamalmarhubi changed the title cargo-fmt should format tests and binaries by default cargo-fmt should format tests by default Feb 2, 2016
@andybarron
Copy link

+1 to this, yes please!

@kamalmarhubi kamalmarhubi mentioned this issue Apr 14, 2016
Closed
Zarokka pushed a commit to Zarokka/rustfmt that referenced this issue Nov 6, 2016
Fix rust-lang#803: cargo-fmt: also format tests
08b17ef
@Zarokka
Copy link

Zarokka commented Nov 6, 2016

I prepared a fix for this Zarokka@08b17ef

but then I saw that PR #1206 seems to address this in a broader way
this is also related to #1126

@conradkleinespel
Copy link

I just tested this and it now seems to work as expected: code in tests/*.rs is formatted, including code from submodules in tests/**/*.rs that is used in tests/*.rs.

@conradkleinespel conradkleinespel mentioned this issue May 16, 2017
Closed
@nrc nrc closed this as completed May 16, 2017
@nrc
Copy link
Member

nrc commented May 16, 2017

Thanks for testing it out!

@dashed
Copy link

dashed commented Sep 24, 2017

This doesn't seem to work anymore as of rustfmt-nightly v0.2.7.

My workaround is: cargo fmt -- ./tests/**/*.rs

marvin-bitterlich added a commit to marvin-bitterlich/coreutils that referenced this issue Apr 1, 2021
@marvin-bitterlich
rm: test format
d90f5c3 
Seems like I got hit by rust-lang/rustfmt#803
It did not ran formatting on the tests
@marvin-bitterlich marvin-bitterlich mentioned this issue Apr 1, 2021
Merged
@daira daira mentioned this issue Jun 3, 2021
Merged
@JonathanLindsey JonathanLindsey mentioned this issue Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kamalmarhubi @dashed @nrc @conradkleinespel @andybarron @Zarokka