Reformat modules in external files #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, @cassiersg! |
An opening paren in generics caused a false-positive detection of args beginning. The result was the creation of comments with some code into it.
This is mandatory.
|
Rebased & added FIXME's with pointers to rust-lang/rust#26755 and rust-lang/rust#26750. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trickiest part was to identify the file a module belongs to. The technique previously used doesn't work with modules that contains only comments (no items), so I used the same algorithm as rustc, looking for the
pathattribute and then defaulting toX.rsandX/mod.rs.At the end, we get all our code reformatted ! (There was a lot of misformatted code ;)
The first two commits are two small issues I discovered while reformatting the code of rustfmt. (I you feel these needs separate issues/PR, please ask it.)
Closes #118