Don't duplicate line numbers when annotating internal errors #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't realize the age of this one when we were discussing in Zulip 😅 In my head I was thinking this was something new and I felt like we'd had a couple prior PRs (even one on the 2x branch) that were attempting to address this, so maybe there's not any duplicative/overlapping PRs after all. So long as everything "looks right" both when formatting an actual file as well as when formatting stdin, this LGTM and after a rebase i'd be happy to merge |
Closes 5463 The `annotate_snippets` crate adds line number and column info to the output, so we don't need to append the line number to the `origin`. Previously, internal errors would be output with the line number twice. See how 478 is duplicated in the example below. ``` error[internal]: line formatted, but exceeded maximum width --> /path/to/file.rs:478:478:101 ``` Now the line number is not duplicated. ``` error[internal]: line formatted, but exceeded maximum width --> /path/to/file.rs:478:101 ```
|
@calebcartwright I just rebased 😁 |
|
Not sure if you've seen #5971, but I think the changes there are fairly similar. Probably not urgent, but wanted to mention it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5463
The
annotate_snippetscrate adds line number and column info to the output, so we don't need to append the line number to theoriginwe pass toannotate_snippets::snippet::Snippet.Previously, internal errors would be output with the line number twice. See how 478 is duplicated in the example below.
Now the line number is not duplicated.