Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Clean up download dir (partials etc) after successful full update run. #2038

Closed
timw4mail opened this issue Oct 4, 2019 · 3 comments · Fixed by #2046
Closed

Comments

@timw4mail
Copy link

timw4mail commented Oct 4, 2019

Edited by @kinnison to reflect decision later in thread

It'd be good to have the downloads directory cleaned up if a full update (i.e. not a single-toolchain update) is completed. That way any partial files etc lying around from failed updates will get cleaned up when we're in a position to believe that all is well and they wouldn't be reused.

I'm prepared to mentor someone in doing this, and suggest you talk to me on Discord about it.


Original from @timw4mail

Describe the problem you are trying to solve
After a while of use, the toolchains and downloads take up a decent amount of disk space.

Describe the solution you'd like
Add a cleanup command, which would remove old downloads and toolchains, perhaps keeping just the most recent on each update channel.

@timw4mail timw4mail changed the title Cleanup command Feature Request: Cleanup command Oct 4, 2019
@kinnison
Copy link
Contributor

kinnison commented Oct 4, 2019

We do sometimes leave .partial and other download files, and that could definitely do with cleaning up. The toolchains themselves only ever keep the one version around; though if you're finding yourself installing a lot of labelled toolchains (e.g. nightly-2019-07-12 or 1.34.0) then it'll be up to you to rustup toolchain uninstall them.

Rather than a cleanup command per-se, it'd probably make more sense if we made it so that any files left in the download dir are deleted iff we complete a full update.

Does that sound good to you?

@timw4mail
Copy link
Author

Yeah, that make sense, and sounds like a better plan than a manual cleanup command.

@kinnison kinnison changed the title Feature Request: Cleanup command Feature Request: Clean up download dir (partials etc) after successful full update run. Oct 8, 2019
BeniCheni added a commit to BeniCheni/rustup.rs that referenced this issue Oct 9, 2019
@BeniCheni
Copy link
Contributor

Friendly note: trying out a branch for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants