Remove unnecessary pub mod #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/rust#18241 is fixed now, so this mod doesn't need to be pub.
|
Thanks! @bors r+ |
|
📌 Commit fc563b5 has been approved by |
bors
added a commit
that referenced
this pull request
May 18, 2017
Remove unnecessary pub mod rust-lang/rust#18241 is fixed now, so this mod doesn't need to be pub. Possible downside: the minimum compiler version to build is now 1.9.0 or thereabouts.
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 18, 2017
Remove unnecessary pub mod rust-lang/rust#18241 is fixed now, so this mod doesn't need to be pub. Possible downside: the minimum compiler version to build is now 1.9.0 or thereabouts.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#18241 is fixed now, so this mod doesn't need to be pub.
Possible downside: the minimum compiler version to build is now 1.9.0 or thereabouts.