-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread toolchain through to error message #1616
Conversation
b634830
to
5c41426
Compare
How about |
I need to work out the right way to produce a "short" toolchain, but yes that wording migh be nicer @h-michael |
5c41426
to
563c9d1
Compare
I've managed to make it say that (and if there's a date associated, channel-date) so I'd appreciate reviews / opinions. If noone has anything negative to say in the next day or so I'll un-WIP this. |
Looks good. We would want to fix the repetition. We should probably split the toolchain into channel and host (is it host or target, actually?) and only report the channel and host if it is different to the target |
So I changed the toolchain to just be I think this probably needs careful thought to decide what's ideal. What is here now is better, but perhaps not ideal. |
Removing the repetition seems to me like a nice-to-have of lesser value than resolving #1596, so I'm happy to accept this as is and trim it later/never. |
☔ The latest upstream changes (presumably #1643) made this pull request unmergeable. Please resolve the merge conflicts. |
In the component-unavailable error case, we need to report the full toolchain rather than just the component and target name. This threads it through and reports it in the error message. Fixes: rust-lang#1596 Signed-off-by: Daniel Silverstone <[email protected]>
563c9d1
to
e05b98b
Compare
I've opted to rebase this onto mater and as per @dwijnand 's observation that something is better than nothing, I commend it for review and ideally merge. I'm not sure entirely how I'd make the change which we've identified as most desirable so I suggest that we take this for now, and consider fixing up the suggestions further after simplification has proceeded somewhat. |
In the component-unavailable error case, we need to report the
full toolchain rather than just the component and target name.
This threads it through and reports it in the error message.
Fixes: #1596
This is not ideal right now, but it's a starting point for discussion.
Currently the error message ends up looking something like:
Clearly the repetition of the target name in the toolchain name isn't ideal, I've been considering
reformatting the message but didn't want to do so without some further input on what might be better.