Check for stray hash when installing a toolchain #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Glamhoth We do indeed need to try and organise a test now, because without a suitable test we be able to protect against this kind of thing causing a problem elsewhere in the future. Do you think you're able to work out where to fit one in? |
|
Sure, I'll try to write it today. |
kinnison
suggested changes
Apr 26, 2019
|
I cleaned up the test. |
Glamhoth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1777
As @kinnison explained - problem is in update-hash that is still present after manual removal of a toolchain. This resulted in the inability to install it again. To fix this problem we now check if there is a stray hash, and delete if so. This is WIP as a test must be written.